Skip to content

Conversation

@TimDu
Copy link

@TimDu TimDu commented Jan 22, 2026

Part of hashicorp/terraform-provider-google#24791

networkservices: added `ull_multicast_domain` field to `google_network_services_multicast_domain` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 22, 2026
@github-actions github-actions bot requested a review from trodge January 22, 2026 23:01
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/networkservices-multicast and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 23, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 166 insertions(+))
google-beta provider: Diff ( 4 files changed, 166 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_multicast_domain (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_multicast_domain" "primary" {
  ull_multicast_domain {
    preconfigured_ull_domain = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 90
Passed tests: 88
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 24, 2026
@github-actions
Copy link

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 27, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 166 insertions(+))
google-beta provider: Diff ( 4 files changed, 166 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_multicast_domain (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_multicast_domain" "primary" {
  ull_multicast_domain {
    preconfigured_ull_domain = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 90
Passed tests: 88
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 27, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 166 insertions(+))
google-beta provider: Diff ( 4 files changed, 166 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 32 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 90
Passed tests: 88
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccNetworkServicesMulticastDomain_networkServicesUllMulticastDomainUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 29, 2026
@github-actions
Copy link

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/networkservices-multicast

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants